chore: send out rabbitmq message for visitors approval and cancellation - #1246
Merged
Conversation
yoganandaness
requested review from
TCMeldrum,
William-Edwards-STFC and
janosbabik
and removed request for
a team
November 1, 2025 13:44
yoganandaness
enabled auto-merge (squash)
November 1, 2025 13:45
TCMeldrum
approved these changes
Nov 3, 2025
janosbabik
reviewed
Nov 3, 2025
janosbabik
left a comment
janosbabik
left a comment
Contributor
There was a problem hiding this comment.
Hi @yoganandaness , some comments from my side.
Contributor
|
|
yoganandaness
force-pushed
the
SWAP-5075-visa-access-to-visitors
branch
from
November 4, 2025 12:14
5a3ed95 to
3ddff47
Compare
Contributor
|
|
janosbabik
approved these changes
Nov 4, 2025
github-actions
Bot
force-pushed
the
SWAP-5075-visa-access-to-visitors
branch
from
November 4, 2025 14:42
3ddff47 to
6eef12a
Compare
…ficeProject/user-office-core into SWAP-5075-visa-access-to-visitors
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Sending out rabbit MQ message with event name PROPOSAL_UPDATED, when a visitor is accepted or cancelled.
Motivation and Context
Currently rabbit MQ messages are sent out whenever users like Proposers, Data access users are added. This can be utilised by external systems(Like VISA) to add the users into the systems. Along with the Proposers and Data Access Users, this PR is to add the Visitors as well.
How Has This Been Tested
Manually
Fixes
Changes
In the messageBroker, rabbitMq message is sent out when the Visitor is accepted or cancelled
Depends on
Tests included/Docs Updated?